Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash autocompletion adds command description to completed line #1508

Closed
averms opened this issue Oct 18, 2021 · 2 comments · Fixed by #1509
Closed

Bash autocompletion adds command description to completed line #1508

averms opened this issue Oct 18, 2021 · 2 comments · Fixed by #1509

Comments

@averms
Copy link

averms commented Oct 18, 2021

This is pretty much #1443 except I think I know how to reproduce it. I'm using podman as the program because I was told (containers/podman#12005) it uses cobra.

  1. Add TAB: menu-complete to .inputrc.
  2. Open bash and type podman --c<TAB>
  3. Note that podman --cgroup-manager (Cgroup manager to use ("cgroupfs"|"systemd")) is added to the current line.
  4. Press enter and get bash: syntax error near unexpected token `('

It is fixed with --no-descriptions, which I don't mind using but I just wanted to make sure the bug is chronicled.
@marckhouzam
Copy link
Collaborator

I can reproduce this, thanks @averms.
I am not familiar with the option TAB: menu-complete so I will have to investigate further.

marckhouzam added a commit to VilledeMontreal/cobra that referenced this issue Oct 19, 2021
@marckhouzam
Support different bash completion options
b9fe4a5 
spf13#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we do special handling for the cases:
- menu-complete/menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam added a commit to VilledeMontreal/cobra that referenced this issue Oct 19, 2021
@marckhouzam
Support different bash completion options
1766812 
spf13#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we do special handling for the cases:
- menu-complete/menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
@marckhouzam marckhouzam mentioned this issue Oct 19, 2021
Merged
@marckhouzam
Copy link
Collaborator

I've posted a fix in #1509.
/cc @Luap99

marckhouzam added a commit to VilledeMontreal/cobra that referenced this issue Oct 19, 2021
@marckhouzam
Support different bash completion options
e1bfc78 
spf13#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we remove descriptions for the following completion types:
- menu-complete
- menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam added a commit to VilledeMontreal/cobra that referenced this issue Oct 21, 2021
@marckhouzam
Support different bash completion options
258452a 
spf13#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we remove descriptions for the following completion types:
- menu-complete
- menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam added a commit to marckhouzam/cobra-completion-testing that referenced this issue Oct 21, 2021
@marckhouzam
Add testing for different bash completion types
9226dbf 
These tests cover the issue: spf13/cobra#1508
and the corresponding fix: spf13/cobra#1509

Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
@marckhouzam marckhouzam mentioned this issue Oct 21, 2021
Merged
marckhouzam added a commit to marckhouzam/cobra-completion-testing that referenced this issue Oct 21, 2021
@marckhouzam
Add testing for different bash completion types
32f0091 
These tests cover the issue: spf13/cobra#1508
and the corresponding fix: spf13/cobra#1509

Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
umarcor pushed a commit to umarcor/cobra that referenced this issue Nov 5, 2021
@marckhouzam @umarcor
Support different bash completion options (spf13#1509)
c6e7365 
spf13#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we remove descriptions for the following completion types:
- menu-complete
- menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
@mislav mislav mentioned this issue Nov 8, 2021
Closed
umarcor pushed a commit to umarcor/cobra that referenced this issue Nov 15, 2021
@marckhouzam @umarcor
Support different bash completion options (spf13#1509)
2b31c95 
spf13#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we remove descriptions for the following completion types:
- menu-complete
- menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
umarcor pushed a commit to umarcor/cobra that referenced this issue Nov 16, 2021
@marckhouzam @umarcor
Support different bash completion options (spf13#1509)
8371a1a 
spf13#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we remove descriptions for the following completion types:
- menu-complete
- menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
umarcor pushed a commit to umarcor/cobra that referenced this issue Nov 25, 2021
@marckhouzam @umarcor
Support different bash completion options (spf13#1509)
9d5e047 
spf13#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we remove descriptions for the following completion types:
- menu-complete
- menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
jpmcb pushed a commit that referenced this issue Dec 7, 2021
@marckhouzam
Support different bash completion options (#1509)
3fed3ef 
#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we remove descriptions for the following completion types:
- menu-complete
- menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
umarcor pushed a commit to umarcor/cobra that referenced this issue Dec 7, 2021
@marckhouzam @umarcor
Support different bash completion options (spf13#1509)
3e06118 
spf13#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we remove descriptions for the following completion types:
- menu-complete
- menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
@lincheney lincheney mentioned this issue Mar 5, 2023
Closed
lincheney added a commit to lincheney/fzf-tab-completion that referenced this issue Mar 5, 2023
@lincheney
bash: indicate that we are like menu-completion
d88bf5b 
fixes #65
related: spf13/cobra#1508
Some completion scripts use $COMP_TYPE to give out different candidates
for different $COMP_TYPE.
Tell them we are like menu-completion so that they give something
compatible with fzf
@marckhouzam marckhouzam mentioned this issue Jun 8, 2023
Open
muscliary pushed a commit to muscliary/cobra that referenced this issue Sep 12, 2023
@marckhouzam
Support different bash completion options (#1509)
e9635b6 
spf13/cobra#1508

Based on the documentation found here
https://www.gnu.org/software/bash/manual/html_node/Commands-For-Completion.html
we remove descriptions for the following completion types:
- menu-complete
- menu-complete-backward
- insert-completions

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
@github-actions github-actions bot mentioned this issue Apr 5, 2024
Merged
5 tasks
This was referenced Apr 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support different bash completion options VilledeMontreal/cobra
2 participants
@marckhouzam @averms