Completion: Capitalize short desc and remove extra space from long #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marckhouzam
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Thanks @fcjr. You are right, the completion command should follow the pattern of the help command.
I assume there is no backwards-compatibility concerns about a command description or help text, but I'll leave that up to the maintainers.
umarcor
approved these changes
Jul 13, 2021
|
As per #1458, the |
Updated to fix the extra newline in the long desc. |
fcjr
changed the title
fcjr
changed the title
|
Just a friendly ping on this, is there any chance this can be merged and released? |
Closed
|
This PR is being marked as stale due to a long period of inactivity |
|
Bumping b/c it was marked as stale =) |
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 5, 2021
This was referenced Nov 10, 2021
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 15, 2021
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 16, 2021
jpmcb
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
helpshort desc is capitalized so we should follow its lead for consistency.Also fixes #1458.