Revert change so help is printed on stdout again #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spf13#1002 For backwards compatibility reasons, and to follow the need of kubernetes/kubernetes#26077 (comment) the help message should be printed on stdout. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
marckhouzam
force-pushed
the
fix/revertStderr
branch
from
86e90ab
to
aa2cd0c
Compare
|
@marckhouzam, since @BoGeM was the one who merged #922, I am going to give him a chance to weigh in here. |
jharshman
approved these changes
Dec 23, 2019
|
I completely agree. Help, especially when requested by the user, belong on stdout. |
marckhouzam
added a commit
to VilledeMontreal/acceptance-testing
that referenced
this pull request
Jan 1, 2020
This reverts commit 187a774. Cobra has reverted the change that had the help message go to stderr: spf13/cobra#1004 Considering what allowed to notice this regression in Cobra was the failure of Helm's acceptance-testing repo, I prefer to continue have the test fail if the help ever goes to stderr.
marckhouzam
added a commit
to VilledeMontreal/acceptance-testing
that referenced
this pull request
Jan 1, 2020
This reverts commit 187a774. Cobra has reverted the change that had the help message go to stderr: spf13/cobra#1004 Considering what allowed to notice this regression in Cobra was the failure of Helm's acceptance-testing repo, I prefer to continue have the test fail if the help ever goes to stderr. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam
added a commit
to helm/acceptance-testing
that referenced
this pull request
Feb 2, 2020
This reverts commit 187a774. Cobra has reverted the change that had the help message go to stderr: spf13/cobra#1004 Considering what allowed to notice this regression in Cobra was the failure of Helm's acceptance-testing repo, I prefer to continue have the test fail if the help ever goes to stderr. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1002
For backwards compatibility reasons, and to follow the need of
kubernetes/kubernetes#26077 (comment)
the help message should be printed on stdout.
/cc @bruceadowns @BoGeM @jharshman