Fix regression when calling *_custom_func #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR spf13#889 introduced a regression where the global variable $c is no longer set when *custom_func is called. This is because $c is re-used by mistake in the read loop. This PR simply changes the name of the variable used in the loop. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
|
|
|
BTW, the helm project has a set of automated regression tests for shell auto-completion, which can help test such changes. |
|
LGTM |
jharshman
added
area/shell-completion
jharshman
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #889 introduced a small regression where the global variable
$cis no longer set when*custom_funcis called. This is because$cis re-used by mistake in the newreadloop.This PR simply changes the name of the variable used in the loop.
I've proposed a PR to the
helm/helmprojet which uses the$cvariable in__helm_custom_funcand when testing with themasterbranch of Cobra, things started failing. With this PR applied, thehelm/helmPR works again.See https://github.com/helm/helm/pull/7078/files#diff-84d051076d41e254e011a57e40b82a34R279 for the line using
$cin the PR./cc @rsteube @jharshman