Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add modTime on folder creation #334

Merged
merged 2 commits into from Feb 5, 2022
Merged

add modTime on folder creation #334

merged 2 commits into from Feb 5, 2022

Conversation

KastenMike
Copy link
Contributor

@KastenMike KastenMike commented Jan 10, 2022 •
edited

NewOsFs behaviour for CreateDir includes modTime on both Mac + Linux.
NewOsFs behaviour for renaming directories does not update modTime.

This makes NewMemMapFs have the same behaviour rather than a time of 0001-01-01 00:00:00 +0000 UTC

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@acabarbaye acabarbaye mentioned this pull request Jan 28, 2022
Closed
@0xmichalis 0xmichalis merged commit 450b30f into spf13:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmichalis 0xmichalis 0xmichalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KastenMike @CLAassistant @0xmichalis