Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot singularize "People's" #965

Closed
weakit opened this issue Oct 16, 2022 · 2 comments
Closed

Cannot singularize "People's" #965

weakit opened this issue Oct 16, 2022 · 2 comments
Labels

Comments

@weakit
Copy link

weakit commented Oct 16, 2022

nouns().toSingular() fails on any text with "People's" in it.

People is correctly singularized to person, but if people's is present, this happens:

Uncaught TypeError: Cannot read properties of undefined (reading 'map')

Pretty easy to reproduce. Just try:

const doc = nlp("How has chemistry improved people's lives?")
doc.nouns().toSingular()
@spencermountain
Copy link
Owner

Thank you. Will look at this today.

spencermountain added a commit that referenced this issue Oct 16, 2022
@spencermountain spencermountain mentioned this issue Oct 16, 2022
Merged
@spencermountain
Copy link
Owner

fixed in 14.5.2
Regarding the singular form of that sentence, I don't know what's best. Right now, the handful of Possessives that are technically-plural are ignored in the inflector - people's right or women's bathroom. There really are probably 4 or 5, and it's sorta an awkward corner in english - the indices's point etc
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants