Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvements]: Add .toLowerCase() API to various functions. #1094

Open
MarketingPip opened this issue Mar 6, 2024 · 1 comment
Open

[Improvements]: Add .toLowerCase() API to various functions. #1094

MarketingPip opened this issue Mar 6, 2024 · 1 comment

Comments

@MarketingPip
Copy link
Contributor

Just doing some playing.... Some functions are missing proper API usage. (or have not been added)

prepositions()
conjunctions()
prepositions()

Are all currently required to be used like example:

     doc
        .match("#Determiner")
        .out("text")
        .toLowerCase()
       doc
        .prepositions()
        .out("text")
        .toLowerCase()
    doc
        .conjunctions()
        .out("text")
        .toLowerCase()

vs standard API usage...

   doc
        .adjectives()
        .toTitleCase()

As well .determiners() might be a nice to have handy & I am sure there are a few others that can be added.

@spencermountain
Copy link
Owner

hey sure! good idea.
Feel free to make a PR for them - I can help add the types and docs for them, if you'd like
cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants