Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning a Loan carries the Loan Preparations along #4012

Open
grantfitzsimmons opened this issue Sep 14, 2023 · 1 comment · May be fixed by #4905
Open

Cloning a Loan carries the Loan Preparations along #4012

grantfitzsimmons opened this issue Sep 14, 2023 · 1 comment · May be fixed by #4905
Assignees
@CarolineDenis
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more
Milestone
Grant's issue list

Comments

@grantfitzsimmons
Copy link
Member

image

Steps to Recreate:

  1. Create a loan with the maximum number of preps an object has
  2. Clone the loan
  3. Save
  4. See error
BusinessRuleException at /api/specify/loan/ ('loan preparation quantity exceeds availability (None: 2 0)',

Should cloning a loan record carry forward the loan preparations? I don't think so.

Specify 7 Crash Report - 2023-09-14T20 39 29.482Z.txt
@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more labels Sep 14, 2023
@bronwyncombs
Copy link

Ran into this while testing Gifts for v7.9.2 release --

Screenshot 2023-12-06 at 2 15 48 PM

Specify 7 Crash Report - 2023-12-06T20_15_35.401Z.txt

  • macOS, Chrome, v7.9.1

@bronwyncombs bronwyncombs added this to the Grant's issue list milestone Dec 6, 2023
@CarolineDenis CarolineDenis self-assigned this May 10, 2024
CarolineDenis added a commit that referenced this issue May 10, 2024
@CarolineDenis
Prevent from carrying preps in interaction during cloning
510d6bd 
Fixes #4012
@CarolineDenis CarolineDenis linked a pull request May 10, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarolineDenis CarolineDenis

Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more
Projects
None yet
Milestone
Grant's issue list
Development

Successfully merging a pull request may close this issue.

Prevent from carrying preps in interaction during cloning specify/specify7
3 participants
@grantfitzsimmons @CarolineDenis @bronwyncombs