-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a view button by default to parent taxon QCBX #4903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad there is a generic solution here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
-
in a taxon data entry form:
-
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and no viewBtn=...
-
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and viewBtn=true
-
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=true
-
Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and no viewBtn=...
-
Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=false
-
can be verified too for other tables and QCBX fields
Everything passed fine, also worked on Cataloger and Accession in Collection Object. Looking good! 🎊
Parent QCBX in Geography would be a good one to test as well, I checked it briefly and it does have the view button visible but I didn't do anything beyond that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and no viewBtn=...
-
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and viewBtn=true
-
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=true
-
Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and no viewBtn=...
-
Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=false
-
can be verified too for other tables and QCBX fields
Behaves correctly with Taxon and Accession QCBXs 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
-
in a taxon data entry form:
-
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and no viewBtn=...
-
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and viewBtn=true
-
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=true
-
Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and no viewBtn=...
-
Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=false
-
can be verified too for other tables and QCBX fields
Looks good! Tested on Taxon and Geography and both worked properly, nice job.
Fixes #4895
Checklist
and self-explanatory (or properly documented)
Testing instructions
in a taxon data entry form:
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and no viewBtn=...
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and viewBtn=true
Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=true
Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and no viewBtn=...
Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=false
can be verified too for other tables and QCBX fields