Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a view button by default to parent taxon QCBX #4903

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented May 10, 2024

Fixes #4895

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • in a taxon data entry form:

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and no viewBtn=...

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and viewBtn=true

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=true

  • Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and no viewBtn=...

  • Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=false

  • can be verified too for other tables and QCBX fields

@CarolineDenis CarolineDenis marked this pull request as ready for review May 13, 2024 13:17
@CarolineDenis CarolineDenis requested review from maxpatiiuk and a team May 13, 2024 13:17
Copy link
Contributor

@melton-jason melton-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad there is a generic solution here!

Copy link
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • in a taxon data entry form:

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and no viewBtn=...

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and viewBtn=true

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=true

  • Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and no viewBtn=...

  • Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=false

  • can be verified too for other tables and QCBX fields

Everything passed fine, also worked on Cataloger and Accession in Collection Object. Looking good! 🎊

Parent QCBX in Geography would be a good one to test as well, I checked it briefly and it does have the view button visible but I didn't do anything beyond that.

@combs-a combs-a requested a review from a team May 14, 2024 15:42
Copy link

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and no viewBtn=...

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and viewBtn=true

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=true

  • Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and no viewBtn=...

  • Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=false

  • can be verified too for other tables and QCBX fields

Behaves correctly with Taxon and Accession QCBXs 👍

@CarolineDenis CarolineDenis added this to the 7.9.6 milestone May 14, 2024
@Areyes42 Areyes42 self-requested a review May 14, 2024 19:35
Copy link

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • in a taxon data entry form:

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and no viewBtn=...

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=false" and viewBtn=true

  • Verify that there is a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=true

  • Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and no viewBtn=...

  • Verify that there is not a view button next to the parent QCBX when the form def has the attribute initialize="editbtn=true" and viewBtn=false

  • can be verified too for other tables and QCBX fields

Looks good! Tested on Taxon and Geography and both worked properly, nice job.

@CarolineDenis CarolineDenis merged commit 31805d5 into production May 21, 2024
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4895 branch May 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a view button to parent query combo boxes by default
6 participants