Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Loan displays "No preparations are available for the following records:" when preps are available #4483

Closed
pashiav opened this issue Jan 31, 2024 · 4 comments · Fixed by #4890
Closed

Create Loan displays "No preparations are available for the following records:" when preps are available #4483

pashiav opened this issue Jan 31, 2024 · 4 comments · Fixed by #4890
Assignees
@CarolineDenis
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more todo:verify Needs Verification
Milestone
7.9.6

Comments

@pashiav
Copy link
Contributor

pashiav commented Jan 31, 2024

Describe the bug
When creating a loan by entering a Catalog Number with preparations available, "No preparations are available for the following records: [catalog number]" is displayed. The user can still click Continue and see that there are preparations available to interact with.

To Reproduce

  1. Find a collection object with preparations available (https://fwri6123-latest.test.specifysystems.org/specify/view/collectionobject/354192/)
  2. Go to Interactions → Loan (https://fwri6123-latest.test.specifysystems.org/specify/overlay/interactions/create/Loan/)
  3. Enter in the CO's catalog number
  4. See line displayed underneath Update button

Expected behavior
Should not display line when there are preparations available.

Evidence

new-issue.mov

OS: macOS Monterey (12.6.5)
Browser: Chrome
Specify 7 Version: edge
Database Name: fwri_6_1_23
@pashiav pashiav added 1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more labels Jan 31, 2024
@CarolineDenis CarolineDenis added the todo:verify Needs Verification label Mar 22, 2024
@pashiav
Copy link
Contributor Author

pashiav commented Apr 17, 2024 •
edited

Recreated on edge while adding a Loan prep to a newly created Loan.

Screen.Recording.2024-04-17.at.11.18.39.AM.mov

Expected behavior on v7.9.3.1: After clicking Next, the text does not appear.

Screen.Recording.2024-04-17.at.11.53.13.AM.mov

@pashiav pashiav modified the milestone: 7.9.4 Apr 17, 2024
@emenslin emenslin added this to the 7.9.4 milestone Apr 18, 2024
@CarolineDenis CarolineDenis self-assigned this Apr 18, 2024
@CarolineDenis
Copy link
Contributor

@pashiav, this is the correct behavior,
It's because at least one row had no prep available and we want to notify the user of that. If he decides to continue it will simply bring him to the prep dialog.
In the case we enter #1 and #2, if #2 has no prep available we want to notify the user that the cat #2 has no prep and the user might want to change the cat # entered

@CarolineDenis CarolineDenis closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
@emenslin
Copy link
Collaborator

emenslin commented May 2, 2024

I think that the wording does not make it clear to the user that there are any preparations available and I think it would be assumed that there are no preparations available at all even though in this case there are some preparations available. I think a possible solution to this could be to just remove this dialog as a whole since on the next dialog the user will see all the preparations that are available.

@emenslin emenslin reopened this May 2, 2024
@CarolineDenis CarolineDenis modified the milestones: 7.9.4, 7.9.6 May 3, 2024
@CarolineDenis
Copy link
Contributor

DECISION:
Will change the warning string from:
No preparations are available for the following records:
TO
No preparations are available for at least one type of preparation in the following records:

@grantfitzsimmons , do you have a preference for the new string?

@CarolineDenis CarolineDenis mentioned this issue May 6, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarolineDenis CarolineDenis

Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more todo:verify Needs Verification
Projects
None yet
Milestone
7.9.6
Development

Successfully merging a pull request may close this issue.

Change unavailable prep string and filter results specify/specify7
3 participants
@CarolineDenis @pashiav @emenslin