Change ConstantScalarType to Type in DisallowedCallParam #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
force-pushed
the
support-callbacks-anywhere
branch
from
b3db2af
to
4b654d4
Compare
This allows for more types to be matched, like a CallbackType. In my use case, I wanted to disallow `array_filter` without specifying a callback. But because the current `DisallowedCallParam` interface only works with `ConstantScalarType` this was not possible.
ruudk
force-pushed
the
support-callbacks-anywhere
branch
from
4b654d4
to
84946da
Compare
|
@spaze Happy New Year! Please have a look when you have time! |
spaze
approved these changes
Jan 6, 2023
|
Happy New Year to you too @ruudk! And thanks for the PR, this makes sense 👍 I'll merge and release soon. |
|
Just released in 2.11.3, thanks again! |
|
With this feature, we now also are able to detect static references like |
|
Nice! Can you write a test, or more like amend an existing one, for that case? (update: #161) |
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Jan 11, 2023
This is an extra commit because things got a little complicated here. Due to changes spaze/phpstan-disallowed-calls 2.11.3 and particularly spaze/phpstan-disallowed-calls#159, more params can be detected and PHPStan started throwing errors in spaze/sri-macros/src/Config.php:126 saying "Calling hash_file() is forbidden". The type that got passed to hash_file() was `StringType`, not `ConstantStringType` and even though the values were the ones allowed, the param was rejected. I had to change sri-macros to pass a union of `ConstantStringType`s and phpstan-disallowed-calls to support union types.
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Jan 11, 2023
This is an extra commit because things got a little complicated here. Due to changes spaze/phpstan-disallowed-calls 2.11.3 and particularly spaze/phpstan-disallowed-calls#159, more params can be detected and PHPStan started throwing errors in spaze/sri-macros/src/Config.php:126 saying "Calling hash_file() is forbidden". The type that got passed to hash_file() was `StringType`, not `ConstantStringType` and even though the values were the ones allowed, the param was rejected. I had to change sri-macros to pass a union of `ConstantStringType`s and phpstan-disallowed-calls to support union types. - spaze/phpstan-disallowed-calls updated from v2.11.2 to v2.11.3 patch See changes: spaze/phpstan-disallowed-calls@v2.11.2...v2.11.3 Release notes: https://github.com/spaze/phpstan-disallowed-calls/releases/tag/v2.11.3 - spaze/sri-macros updated from v2.0.0 to v2.0.1 patch See changes: spaze/sri-macros@v2.0.0...v2.0.1 Release notes: https://github.com/spaze/sri-macros/releases/tag/v2.0.1
spaze
added a commit
to spaze/michalspacek.cz
that referenced
this pull request
Jan 11, 2023
This is an extra commit because things got a little complicated here. Due to changes spaze/phpstan-disallowed-calls 2.11.3 and particularly spaze/phpstan-disallowed-calls#159, more params can be detected and PHPStan started throwing errors in spaze/sri-macros/src/Config.php:126 saying "Calling hash_file() is forbidden". The type that got passed to hash_file() was `StringType`, not `ConstantStringType` and even though the values were the ones allowed, the param was rejected. I had to change sri-macros to pass a union of `ConstantStringType`s and phpstan-disallowed-calls to support union types. - spaze/phpstan-disallowed-calls updated from v2.11.3 to v2.11.4 patch See changes: spaze/phpstan-disallowed-calls@v2.11.3...v2.11.4 Release notes: https://github.com/spaze/phpstan-disallowed-calls/releases/tag/v2.11.4 - spaze/sri-macros updated from v2.0.0 to v2.0.1 patch See changes: spaze/sri-macros@v2.0.0...v2.0.1 Release notes: https://github.com/spaze/sri-macros/releases/tag/v2.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for more types to be matched, like a CallbackType.
In my use case, I wanted to disallow
array_filterwithout specifying a callback.But because the current
DisallowedCallParaminterface only works withConstantScalarTypethis was not possible.