Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache sheet instances for current runtime #47

Merged
merged 1 commit into from Mar 24, 2020
Merged

cache sheet instances for current runtime #47

merged 1 commit into from Mar 24, 2020

Conversation

Gummibeer
Copy link
Contributor

fixes #46

This PR could be breaking for users relying on different sheet instances and/or updating a sheet content file during runtime.

@sebastiandedeyne sebastiandedeyne merged commit 81f0191 into spatie:master Mar 24, 2020
@sebastiandedeyne
Copy link
Member

Looks great, thanks!

@Gummibeer Gummibeer deleted the ft-issue-46 branch March 24, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keep sheet instance references during runtime
2 participants