Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add path to sheet #42

Merged
merged 1 commit into from Mar 24, 2020
Merged

add path to sheet #42

merged 1 commit into from Mar 24, 2020

Conversation

Gummibeer
Copy link
Contributor

fixes #37

@Gummibeer
Copy link
Contributor Author

👊 poke

@sebastiandedeyne
Copy link
Member

What would you think of adding this to the attributes array? Or too dangerous for breaking changes?

@Gummibeer
Copy link
Contributor Author

I wouldn't add it to the attributes because this would prevent a path attribute.

@sebastiandedeyne sebastiandedeyne merged commit 0b19772 into spatie:master Mar 24, 2020
@Gummibeer Gummibeer deleted the ft-sheet-path branch March 24, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiandedeyne sebastiandedeyne Awaiting requested review from sebastiandedeyne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FilesystemRepository::all() return should have path as array key
2 participants
@Gummibeer @sebastiandedeyne