feat: Driver with JSONPath support #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
force-pushed
the
json-path-regex-snapshot
branch
from
39ac954
to
7057c51
Compare
|
Great proposal. Thanks. |
|
The tests seem to fail, could you take a look at that? |
|
oh snap, yes, i will seg fault 👀 😆 |
chr-hertel
force-pushed
the
json-path-regex-snapshot
branch
from
0894566
to
9827f7c
Compare
|
that's pretty weird ... running on ubuntu php8.3 with the same command:
doesn't look like this thing is flaky, so it's most likely my change ... can't wrap my head around it - need to give it another thought later. |
chr-hertel
force-pushed
the
json-path-regex-snapshot
branch
from
9827f7c
to
bd9b273
Compare
|
@freekmurze would you mind to just approve another run for the pipeline? i set up a seperate repo with the same pipeline and all phpunit jobs passed: |
|
Found another issue while testing - need to extend this further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing JsonPathDriver - resolves #190
With this feature it is possible to have changing values in a JSON snapshot and add regex assertions on those values.
Implementation
JsonDriverwith an optional argument instead of a separate driverExamples
Example 1: Simple Document
The corresponding test code would look like this:
Example 2: json:api
The corresponding test code would look like this: