New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix O(n^2) behavior when checking for duplicate attributes (libgumbo) #2568

Open

flavorjones opened this issue Jun 5, 2022 · 0 comments

Labels

topic/gumbo topic/performance

Member

flavorjones commented Jun 5, 2022

Please describe the bug

Originally rubys/nokogumbo#144

Code was added to limit the number of attributes supported per element to prevent DoS attacks: rubys/nokogumbo#143

That safety limit is here: https://github.com/sparklemotion/nokogiri/blob/main/gumbo-parser/src/tokenizer.c#L792

It would be great to support more attributes by addressing performance concerns in the implementation.

flavorjones added the topic/performance label

flavorjones mentioned this issue

Fix O(n^2) behavior when checking for duplicate attributes rubys/nokogumbo#144

Closed

flavorjones added the topic/gumbo label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment