Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better c99 fix #2304

Merged
merged 3 commits into from Aug 9, 2021
Merged

better c99 fix #2304

merged 3 commits into from Aug 9, 2021

Conversation

flavorjones
Copy link
Member

What problem is this PR intended to solve?

See #2302 and conversation at #2303. This PR explicitly enables C90- and C99-isms in the C extension code.

cc @stevecheckoway

@flavorjones flavorjones mentioned this pull request Aug 6, 2021
Copy link
Contributor

@stevecheckoway stevecheckoway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI shows -std=c99 being passed to the compiler. mkmf is…unpredictable at times.

ext/nokogiri/extconf.rb Outdated Show resolved Hide resolved
@flavorjones
Copy link
Member Author

LGTM, assuming CI shows -std=c99 being passed to the compiler. mkmf is…unpredictable at times.

image

👍

@flavorjones
Copy link
Member Author

The failing CI jobs are related to the windows environments not being able to bootstrap the ruby environment right now. I'm going to ignore those errors.

@flavorjones
Copy link
Member Author

OK, no objections having been raised, I'm going to merge this.

@flavorjones flavorjones merged commit e3435aa into main Aug 9, 2021
@flavorjones flavorjones deleted the 2303-better-c99-fix branch August 9, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants