Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BSD support for libgumbo #2299

Merged
merged 4 commits into from Aug 3, 2021
Merged

Conversation

flavorjones
Copy link
Member

What problem is this PR intended to solve?

The makefile in gumbo-parser/src/Makefile contained Gnu-isms that are not compatible with BSD make (see #2298). This PR adds CI coverage for FreeBSD and updates the makefile to be portable across both flavors of make.

Have you included adequate test coverage?

Yes! New jobs in the ci pipeline will cover BSD with and without system libraries.

Does this change affect the behavior of either the C or the Java implementations?

Just the C implementation on BSD, and just at install-time.

since 5c6f7c1 when we started passing CFLAGS, et al through
environment variables instead of through the make command line.

Although this wasn't doing any harm on gnu-based systems, `override`
is a gnu-ism and we need to support builds on bsd systems.

Related to #2298
The wildcard and patsubst functions, as well as $^, don't work in BSD
make. Let's just inline everything to make it simple and portable.

Related to #2298
@flavorjones flavorjones force-pushed the flavorjones-bsd-gumbo-support branch 2 times, most recently from f4a0e91 to 1159a9b Compare August 3, 2021 14:09
@flavorjones flavorjones added this to the v1.12.x patch releases milestone Aug 3, 2021
@flavorjones flavorjones merged commit 0e5fece into main Aug 3, 2021
@flavorjones flavorjones deleted the flavorjones-bsd-gumbo-support branch August 3, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant