Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should test against major downstream consumers #2293

Closed
7 tasks done
flavorjones opened this issue Jul 14, 2021 · 3 comments
Closed
7 tasks done

CI should test against major downstream consumers #2293

flavorjones opened this issue Jul 14, 2021 · 3 comments

Comments

@flavorjones
Copy link
Member

flavorjones commented Jul 14, 2021

Nokogiri is a major part of the Ruby and Rails ecosystem, and we want to make sure we're doing our best to avoid introducing surprising breaking changes in downstream consumers by testing the latest (and maybe HEAD) of some downstream libraries against Nokogiri's origin/main.

I wrote a script to find transitive reverse dependencies with lots of downloads, but there are other consumers like ActiveSupport::XmlMini that we should also consider.

As a first pass, I think the downstream consumers that we test should include gems likely to depend on edge case behavior (like semi-public APIs, broken markup cleanup, or sanitization):

Here's the output from the script linked to above, all transitive reverse dependencies with more than 50 million downloads:

  • mime-types: 427192129
  • actionpack: 301924540
  • rails: 291427727
  • actionmailer: 286621408
  • railties: 285189135
  • sprockets: 262728161
  • mime-types-data: 246581469
  • actionview: 245752445
  • loofah: 229877006
  • sprockets-rails: 220115681
  • rails-html-sanitizer: 214929483
  • rails-dom-testing: 214021258
  • rest-client: 197506600
  • jquery-rails: 164304611
  • coffee-rails: 149628440
  • httparty: 140741625
  • actioncable: 136061936
  • awesome_print: 126815236
  • rspec-rails: 125020709
  • mimemagic: 118289077
  • capybara: 115351581
  • responders: 108551246
  • xpath: 105908875
  • devise: 102297652
  • kaminari: 85638960
  • activestorage: 85143954
  • haml: 83777188
  • fog-core: 80990363
  • fog-json: 76526485
  • marcel: 76479842
  • fog-aws: 73467593
  • fog-xml: 70598608
  • autoprefixer-rails: 66030405
  • rspec_junit_formatter: 63620797
  • factory_bot_rails: 60680591
  • oauth: 59455942
  • paperclip: 53141734
  • kaminari-actionview: 52880566
  • web-console: 51907828
  • fastlane: 51243313
  • lograge: 50700055
@flavorjones
Copy link
Member Author

I've labeled this "help wanted" because I think it's something that doesn't require deep knowledge of Nokogiri's internals to do.

@flavorjones
Copy link
Member Author

flavorjones commented Feb 25, 2022

Another example that would have been helpful to have is webrat, see #2469

Edit: the webrat test suite is suffering from bitrot pretty badly and I couldn't easily get it running.

flavorjones added a commit that referenced this issue May 9, 2022
- loofah
- rails-html-sanitizer
- sanitize

See #2293
flavorjones added a commit that referenced this issue May 9, 2022
- signer
- Viewpoint
- ActiveSupport::XmlMini

See #2293
flavorjones added a commit that referenced this issue May 9, 2022
- signer
- Viewpoint
- ActiveSupport::XmlMini

See #2293
flavorjones added a commit that referenced this issue May 9, 2022
- loofah
- rails-html-sanitizer
- sanitize
- signer
- Viewpoint
- ActiveSupport::XmlMini

See #2293
flavorjones added a commit that referenced this issue May 9, 2022
- loofah
- rails-html-sanitizer
- sanitize
- signer
- Viewpoint
- ActiveSupport::XmlMini

See #2293
@flavorjones
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant