New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI should test against major downstream consumers #2293
Labels
Comments
I've labeled this "help wanted" because I think it's something that doesn't require deep knowledge of Nokogiri's internals to do. |
5 tasks
Another example that would have been helpful to have is webrat, see #2469 Edit: the webrat test suite is suffering from bitrot pretty badly and I couldn't easily get it running. |
flavorjones
added a commit
that referenced
this issue
May 8, 2022
flavorjones
added a commit
that referenced
this issue
May 9, 2022
- loofah - rails-html-sanitizer - sanitize See #2293
flavorjones
added a commit
that referenced
this issue
May 9, 2022
- signer - Viewpoint - ActiveSupport::XmlMini See #2293
flavorjones
added a commit
that referenced
this issue
May 9, 2022
- signer - Viewpoint - ActiveSupport::XmlMini See #2293
flavorjones
added a commit
that referenced
this issue
May 9, 2022
- loofah - rails-html-sanitizer - sanitize - signer - Viewpoint - ActiveSupport::XmlMini See #2293
flavorjones
added a commit
that referenced
this issue
May 9, 2022
- loofah - rails-html-sanitizer - sanitize - signer - Viewpoint - ActiveSupport::XmlMini See #2293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Nokogiri is a major part of the Ruby and Rails ecosystem, and we want to make sure we're doing our best to avoid introducing surprising breaking changes in downstream consumers by testing the latest (and maybe HEAD) of some downstream libraries against Nokogiri's
origin/main
.I wrote a script to find transitive reverse dependencies with lots of downloads, but there are other consumers like
ActiveSupport::XmlMini
that we should also consider.As a first pass, I think the downstream consumers that we test should include gems likely to depend on edge case behavior (like semi-public APIs, broken markup cleanup, or sanitization):
webrat? (Breaking Change in to_xpath method breaks webrat #2469)Here's the output from the script linked to above, all transitive reverse dependencies with more than 50 million downloads:
The text was updated successfully, but these errors were encountered: