upgrade to libxml 2.9.12 #2234
Merged
upgrade to libxml 2.9.12 #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because this is about to change in libxml 2.9.12
flavorjones
force-pushed
the
2233-upgrade-to-libxml-2-9-12
branch
2 times, most recently
from
1323d81
to
3f4bd62
Compare
See upstream libxml2 commit 6f1470a where the recursion limit is hardcoded to 5000 stack frames.
libxml 2.9.12 fixes the parser to ignore namespaces in HTML docs, likely in upstream commit 21ca882.
flavorjones
force-pushed
the
2233-upgrade-to-libxml-2-9-12
branch
from
3f4bd62
to
5436f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Upgrade to libxml 2.9.12, see #2233.
Have you included adequate test coverage?
Some tests changed, one test removed, to accommodate libxml2 behavior changes.
Does this change affect the behavior of either the C or the Java implementations?
Obvs just the CRuby implementation.