Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up tests #2215

Merged
merged 3 commits into from Apr 6, 2021
Merged

clean up tests #2215

merged 3 commits into from Apr 6, 2021

Conversation

flavorjones
Copy link
Member

What problem is this PR intended to solve?

Just cleaning up some tests, making some of the GC-specific tests more declarative and introducing a standard way to skip platform-specific tests.

@codeclimate
Copy link

codeclimate bot commented Apr 6, 2021

Code Climate has analyzed commit 72d96fe and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 94.0% (0.0% change).

View more on Code Climate.

@flavorjones flavorjones force-pushed the flavorjones-valgrind-test-helpers branch from 8f6c714 to d33b021 Compare April 6, 2021 17:42
because forking is slow and this cuts a few seconds off the test suite
@flavorjones flavorjones merged commit 5562eb7 into main Apr 6, 2021
@flavorjones flavorjones deleted the flavorjones-valgrind-test-helpers branch April 6, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant