You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interestingly, this is fixed now (3d90c6d) and a quick git-bisect shows that this was fixed by 35aa88b.
The first test is Nokogiri::XML::TestDocument#test_xpath_syntax_error which parses an invalid xpath query and asserts on the exception raised. XPathContext#evaluate uses Nokogiri_error_raise as the error handler, and this is bad for a few reasons that I've outlined at #1610, and in fact have fixed on a branch in 426fd89.
One of the reasons Nokogiri_error_raise is bad is that it doesn't give XPathContext#evaluate a chance to reset error handlers, and so we see that the exception is raised leaving the libxml2 global error handler set to `Nokogiri_error_raise.
The second test, which is failing in the description, is Nokogiri::XML::SAX::TestParserContext#test_from_file which parses a document using the SAX parser. As noted in #2168 and #2169, the SAX parser in v1.11.0 does not set an error handler, and so this test "inherits" Nokogiri_error_raise and ... this test fails because the exception is raised.
Please describe the bug
The CI test run at https://ci.nokogiri.org/teams/nokogiri-core/pipelines/nokogiri/jobs/cruby-gem-test/builds/66 failed, and a rerun passed. We don't generally have flaky tests, so I investigated.
Thanks to
minitest-bisect
this was a cinch to narrow down to:Help us reproduce what you're seeing
You should be able to repro by running:
The text was updated successfully, but these errors were encountered: