You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On one ruby 2.5.8p224 (2020-03-31 revision 67882) [x86_64-darwin18] Rails app, there is no regression. It is darwin18 as pointed above, so compiling like before, but I still wanted to point out the absence of regressions 😄
On one JRuby app (tested on both jruby 9.2.13.0 (2.5.7) 2020-08-03 9a89c94bcc OpenJDK 64-Bit Server VM 25.232-b09 on 1.8.0_232-b09 +jit [darwin-x86_64] and jruby 9.2.5.0 (2.5.0) 2018-12-06 6d5a228 OpenJDK 64-Bit Server VM 25.232-b09 on 1.8.0_232-b09 +jit [darwin-x86_64]), I see many test failures as soon as I upgrade from Nokogiri 1.10.10 to any of the 1.11.0.rc[1/2/3] releases. Something appears to have been botched there.
I will investigate more on the JRuby failures.
Thanks for your work on accelerating the installation, much appreciated!
Quick feedback:
ruby 2.5.8p224 (2020-03-31 revision 67882) [x86_64-darwin18]Rails app, there is no regression. It isdarwin18as pointed above, so compiling like before, but I still wanted to point out the absence of regressions 😄jruby 9.2.13.0 (2.5.7) 2020-08-03 9a89c94bcc OpenJDK 64-Bit Server VM 25.232-b09 on 1.8.0_232-b09 +jit [darwin-x86_64]andjruby 9.2.5.0 (2.5.0) 2018-12-06 6d5a228 OpenJDK 64-Bit Server VM 25.232-b09 on 1.8.0_232-b09 +jit [darwin-x86_64]), I see many test failures as soon as I upgrade from Nokogiri1.10.10to any of the1.11.0.rc[1/2/3]releases. Something appears to have been botched there.I will investigate more on the JRuby failures.
Thanks for your work on accelerating the installation, much appreciated!
Originally posted by @thbar in #2075 (comment)
The text was updated successfully, but these errors were encountered: