New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native gems: centos6 support #2081
Comments
tagging @twk3 so he can follow along as the original reporter |
Now that centos 6 has hit its EOL, this is likely isn't very important. We no longer ship centos 6 packages for GitLab (which is where I ran into this), so I am no longer in need of a fix. |
@twk3 Thanks for closing the loop here. I'd still like to see if we can make this fail a little more gracefully on systems with older glibc versions, so I'll leave it open until I can investigate. |
I first used manylinux2010 for rake-compiler-dock-1.1.0 which produced a centos-6 compatible binary, but switched to manylinux2014 later on, since I don't think we want to support systems that are EOL. Regarding the error message, I don't think it's too bad. I understood it at the very first reading. |
Specifically, older systems may not meet our expectations for glibc, and this commit attempts to help those poor souls find a path forward. I manually tested this change using the OCI image at: registry.gitlab.com/gitlab-org/gitlab-omnibus-builder/centos_6:0.0.72 Closes #2081
I've created a PR at #2156 to try to be more helpful for folks who are in this situation. If they're used to Nokogiri "just working" on their system, they may not understand how to address the situation (even if they understand the exception message). |
(Originally mentioned at #2075 (comment))
On Centos6, running a version of Ruby compiled like this, we see the following error message when loading the nokogiri.so shared library:
I'm not deeply familiar with our glibc requirements, but if we go back to the early days of Linux native gems, in #1571, @larskanis mentions that we need GLIBC 2.17 or later (and we check for this here).
It looks like CentOS/6.10 is based on glibc 2.12 which might explain why this isn't working -- but the error message is a little confusing if this is the case. @larskanis can you take a look and confirm my understanding?
To Reproduce
The text was updated successfully, but these errors were encountered: