support "keyword attributes" via new methods on Nokogiri::XML::Node #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and do the same for Searchable related to #1996
- #kwattr_values - #kwattr_add - #kwattr_append - #kwattr_remove and rewrite CSS class convenience methods using their #kwattr analog. related to flavorjones/loofah#173
flavorjones
changed the title
|
This PR is still in progress ... need to finish docs for the kwattr methods. |
- Node#classes - Node#add_class - Node#append_class - Node#remove_class
flavorjones
force-pushed
the
flavorjones-keyword-attributes
branch
from
47fe1ff
to
66649ee
Compare
This was referenced Mar 5, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nokogiri::XML::Node currently supports some convenience methods for dealing with CSS classes (
#classes,#add_class,#append_class, and#remove_class).There are other HTML attributes, though, that are interpreted as sets of keywords; for example
rel(see https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel).Further, some of this keyword-attribute functionality has been built into
Loofahin a really inconvenient way (see flavorjones/loofah#173).This PR creates a set of keyword-attribute convenience methods on Node:
#kwattr_values#kwattr_add#kwattr_append#kwattr_removeand re-implements the CSS class convenience methods using these new, more general, methods.
Finally, this PR improves the documentation for both sets of convenience classes.