Remove support for future script macros #1871
Conversation
|
Hey @ksolo! Thanks so much for submitting this, I agree we should remove this support in Nokogiri. It looks like this PR failed CI because the test you added is being run even when Nokogiri is built against the "system" libxml2 (in our CI, this is Ubuntu). We should skip this test unless we're running with the vendored libxml2. An example of how to do this is in https://github.com/sparklemotion/nokogiri/blob/master/test/html/test_attributes.rb Basically, skip the test if Does that make sense? |
|
@flavorjones That makes perfect sense. Thank you! |
libxml2 added support for future script macros based on the below specification https://www.w3.org/TR/html401/appendix/notes.html#h-B.7.1 This syntax was reserved, but has yet to be defined. It is still unclear how these macros will be used and what risks will be created if/when implemented. This PR removes support until more information is provided.
ksolo
force-pushed
the
revert-libxml2-patch
branch
from
fbd54a0
to
f9d58f6
Compare
|
Code Climate has analyzed commit f9d58f6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 93.5%. View more on Code Climate. |
|
👍 |
libxml2 added support for future script macros based on the below
specification
https://www.w3.org/TR/html401/appendix/notes.html#h-B.7.1
This syntax was reserved, but has yet to be defined. It is still unclear
how these macros will be used and what risks will be created if/when
implemented.
This PR removes support until more information is provided.