Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows cross build for ruby-2.6 #1850

Merged

Conversation

larskanis
Copy link
Member

This also adds a JRuby task which makes use of new JRuby support in rake-compiler-dock-0.7.0. I'm not sure whether this is something for build_all.

Fixes #1842 .

Add a JRuby task which makes use of new JRuby support in rake-compiler-dock-0.7.0
@flavorjones flavorjones added this to the v1.10.0 milestone Dec 27, 2018
@flavorjones
Copy link
Member

@larskanis Thank you! Will merge in the morning and planning to cut v1.10.0 this week.

@flavorjones flavorjones merged commit e561fc3 into sparklemotion:master Dec 28, 2018
flavorjones added a commit that referenced this pull request Dec 28, 2018
@flavorjones
Copy link
Member

... And I've updated build_all to use the new task. Thanks again!

@flavorjones
Copy link
Member

@larskanis I've just cut v1.10.0.rc1, could you please make sure the windows gems look OK to you?

@larskanis
Copy link
Member Author

@flavorjones Looks good to me. I tested v1.10.0.rc1 on Windows server 2016:

  • binary gems on ruby-2.4-i386 and ruby-2.6-x64 running the nokogiri test suite from github
  • rake compile test on github master branch on ruby-2.4-i386 and ruby-2.6-x64
  • gem inst --pre --platform ruby nokogiri and run tests on ruby-2.6.0

Everthing succeeded. rake compile on ruby-2.6 emitted a lot of warnings kind of:

  • warning: cast discards 'const' qualifier from pointer target type
  • warning: Please include winsock2.h before windows.h
    They aren't new and I believe the latter one is a ruby issue.

@flavorjones
Copy link
Member

Awesome, thank you for performing those tests!

Yes, the compilation warnings have been around for a while and aren't new with 2.6. I've tried squashing them but couldn't find a way to do it without introducing #pragmas all over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants