Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML::DocumentFragment#dup should return an instance of the same class #1846

Closed
flavorjones opened this issue Dec 18, 2018 · 3 comments
Closed

XML::DocumentFragment#dup should return an instance of the same class #1846

flavorjones opened this issue Dec 18, 2018 · 3 comments

Comments

@flavorjones
Copy link
Member

flavorjones commented Dec 18, 2018 •
edited

In v1.9.0, DocumentFragment#dup started always returning an XML::DocumentFragment which not only breaks HTML::DocumentFragment#dup but also any other subclasses of XML::DocumentFragment, such as the Loofah gem's Loofah::HTML::DocumentFragment (see flavorjones/loofah#161).

Working on this now.
@flavorjones flavorjones mentioned this issue Dec 18, 2018
Closed
@flavorjones flavorjones changed the title DocumentFragment#dup does not preserve decorators XML::DocumentFragment#dup should return an instance of the same class Dec 18, 2018
@flavorjones
Copy link
Member Author

This bug was introduced in f2f3a3b first appearing in v1.9.0.

@flavorjones
Copy link
Member Author

Cutting a new release v1.9.1 with this fix. Should be in the next 30 minutes.

flavorjones added a commit that referenced this issue Dec 18, 2018
@flavorjones
limit test of libxml-specific DocumentFragment#dup behavior
db26a04 
... to only running when testing the libxml2 impl.

Related to #1846 and #1063.
@flavorjones
Copy link
Member Author

v1.9.1 is out.

This was referenced Mar 14, 2021
Closed
Merged
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flavorjones