Fix misuse of MAKEFILE_CONFIG #1820
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the values of `RbConfig::MAKEFILE_CONFIG` are intended to use in Makefile and may contain make macros, so a path in it may not match /gcc/, nor cannot execute directly. Use `RbConfig::CONFIG`, whose values are expanded, for such porpose instead.
|
Thank you! All tests are green, so I'm merging. |
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the values of
RbConfig::MAKEFILE_CONFIGare intended to use in Makefile and may contain make macros, so a path in it may not match/gcc/, nor cannot execute directly.Use
RbConfig::CONFIG, whose values are expanded, for such porpose instead.