Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull in upstream libxml2 patches #1786

Merged
merged 1 commit into from Aug 29, 2018
Merged

pull in upstream libxml2 patches #1786

merged 1 commit into from Aug 29, 2018

Conversation

flavorjones
Copy link
Member

based on USN-3739-1 and -2.

see related #1785.

based on USN-3739-1 and -2.

see related #1785.
@flavorjones
Copy link
Member Author

If there are no objections in the next 48 hours, I'd like to ship this change as part of v1.8.5. Please do comment if you have opinions!

Copy link
Member

@larskanis larskanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did some tests on Windows with rubyinstaller-2.4.4: rake test, rake gem, gem install with and without system libraries. Everything worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants