Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API for /setting/ line number #1657

Closed
fulldecent opened this issue Jun 20, 2017 · 3 comments
Closed

Create API for /setting/ line number #1657

fulldecent opened this issue Jun 20, 2017 · 3 comments

Comments

@fulldecent
Copy link
Contributor

There is a desire to /set/ line numbers on XML nodes. This is for constructed nodes.

Please see downstream discussion at rubys/nokogumbo#53 (comment)

Related, also see discussion on libxml and line numbers greater than 65535 (and workarounds) at:


PR coming

@fulldecent
Copy link
Contributor Author

PR added at #1658

@flavorjones
Copy link
Member

@fulldecent you seem to be bringing up two distinct issues here:

  • a feature request, to set line numbers on nodes.
  • a bug report about line numbers being limited to a short int, which is unfortunately a limitation in libxml2's data structure; Nokogiri here is behaving exactly as the libxml2 maintainers wish/constrain it to.

The first is being addressed in your PR at #1658, which is where I'd like to focus the conversation about that feature request.

The second has been discussed in the issue you reference, and so unless there's new information or a concrete suggestion on how to address this behavior (I don't see one here?), I'd prefer to not reopen that discussion.

So, I'm going to close this issue out -- let's continue the API conversation at #1658.

@fulldecent
Copy link
Contributor Author

Got it. I understand the short int issue and am not looking to rock the boat on libxml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants