Add method #wrap to Nokogiri::XML::Element

[ethirajsrinivasan]

No description provided.

[ethirajsrinivasan]

The build for travis has failed since rvm 2.2.5 in mac OS is not installed .It is an issue as per travis-ci/travis-ci#6467

[flavorjones]

Hello! Thank you so much for submitting this! I'd love to add a #wrap method.

I have a few suggestions, though, if you don't mind hearing me out.

First, #wrap seems useful for more than just Elements. I'd like to be able to wrap Comment nodes and Text nodes as well. What would you think about moving this method into XML::Node?

I realize that not every node type will be wrappable, but the fact that NodeSet#wrap doesn't care about this today means I really don't care about it for Node, either.

Which brings me to my second suggestion, which is to re-implement NodeSet#wrap to delegate to the contents. Something like this might be appropriate:

def wrap html
  map { |node| node.wrap html }
end

I apologize that I haven't replied before now. If you're not interested in making these changes, please let me know, because I think this is a good feature to have.

[ethirajsrinivasan]

@flavorjones I would love to make these changes.Will update my PR.

[ethirajsrinivasan]

@flavorjones i have made changes to the PR please have a look at it.

[flavorjones]

Thanks for making the suggested changes. I'd like to take some time to look at NodeSet#wrap, since it looks like the builder-as-block-argument should be broken; but tests passed. This indicates to me we're missing some test coverage, and I'd like to investigate.

[ethirajsrinivasan]

@flavorjones any improvements on the PR

[flavorjones]

I'm so sorry for my slow responses. This work needs to be rebased onto master to pass tests; I've done this at #1828. As soon as it goes green in CI, I'll merge it.

[flavorjones]

Merging manually! Thank you again for your patience and for the great API improvement. Your contribution will be noted in the CHANGELOG.