New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
line numbers not working as expected #1493
Comments
Thanks Mike, if you have any ideas but don't have time to try them out I'd be happy to take it on. The farthest I've gotten so far is |
I have been working on a project that uses libxml2, so in my searches I found this issue. Since this is still marked as open, I hope this is still relevant. It looks like xmlGetLineNo just returns the results of xmlGetLineNoInternal, which you can find, here: |
feat(cruby): support line numbers larger than a short --- **What problem is this PR intended to solve?** As noted in #1493, #1617, #1505, #1003, and #533, libxml2 has not historically supported line numbers greater than a `short int`. Starting in libxml v2.9.0, setting the parse option `BIG_LINES` would allow tracking line numbers in longer documents. Specifically this PR makes the following changes: - set `BIG_LINES` parse option by default which will allow `Node#line` to return large integers - allow `Node#line=` to set large line numbers on text nodes Fixes #1764 **Have you included adequate test coverage?** Yes! **Does this change affect the behavior of either the C or the Java implementations?** JRuby's Xerces-based implementation did not suffer from this particular shortcoming, although its line number functionality is questionable in other ways (see #2177 / b32c875).
This will be fixed in v1.13. |
(reported on nokogiri-talk by @justinthec)
I haven't had time to look into this, but wanted to capture it so that it wouldn't get forgotten.
The text was updated successfully, but these errors were encountered: