From d306fc43179d6c1276cfa1bfad1a615c1cb62eda Mon Sep 17 00:00:00 2001 From: John Shahid Date: Tue, 15 Sep 2020 09:11:07 -0400 Subject: [PATCH] Do not use a default encoding when parsing XML documents. This change fixes the tests in #2080, but introduces more errors. The errors are mostly unexpected null encoding when parsing an HTML document. --- ext/java/nokogiri/internals/XmlDomParserContext.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/java/nokogiri/internals/XmlDomParserContext.java b/ext/java/nokogiri/internals/XmlDomParserContext.java index 3a75d72f6f..d400faae0c 100644 --- a/ext/java/nokogiri/internals/XmlDomParserContext.java +++ b/ext/java/nokogiri/internals/XmlDomParserContext.java @@ -93,7 +93,7 @@ public XmlDomParserContext(Ruby runtime, IRubyObject options) { public XmlDomParserContext(Ruby runtime, IRubyObject encoding, IRubyObject options) { super(runtime); this.options = new ParserContext.Options(RubyFixnum.fix2long(options)); - java_encoding = NokogiriHelpers.getValidEncoding(encoding); + java_encoding = NokogiriHelpers.getValidEncodingOrNull(encoding); ruby_encoding = encoding; initErrorHandler(); initParser(runtime);