From 371f5535b4a8ba0fb8ac1f02481e2bda054fbded Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Wed, 27 Apr 2022 08:03:10 -0400 Subject: [PATCH] style(rubocop): Style/RedundantInitialize is smarter now --- lib/nokogiri/xml/node.rb | 4 ++-- nokogiri.gemspec | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/nokogiri/xml/node.rb b/lib/nokogiri/xml/node.rb index 09b12788b4..c90dea6c18 100644 --- a/lib/nokogiri/xml/node.rb +++ b/lib/nokogiri/xml/node.rb @@ -123,8 +123,8 @@ class Node # [Yields] Nokogiri::XML::Node # [Returns] Nokogiri::XML::Node # - def initialize(name, document) # rubocop:disable Style/RedundantInitialize - # This is intentionally empty. + def initialize(name, document) + # This is intentionally empty, and sets the method signature for subclasses. end ### diff --git a/nokogiri.gemspec b/nokogiri.gemspec index 75036af269..369003ddd0 100644 --- a/nokogiri.gemspec +++ b/nokogiri.gemspec @@ -330,7 +330,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency("rake-compiler-dock", "~> 1.2") spec.add_development_dependency("rdoc", "~> 6.3") spec.add_development_dependency("rexical", "~> 1.0.7") - spec.add_development_dependency("rubocop", "~> 1.23") + spec.add_development_dependency("rubocop", "~> 1.28", ">= 1.28.2") spec.add_development_dependency("rubocop-minitest", "~> 0.17") spec.add_development_dependency("rubocop-performance", "~> 1.12") spec.add_development_dependency("rubocop-rake", "~> 0.6")