diff --git a/CHANGELOG.md b/CHANGELOG.md index 77358751b4..c59d60b325 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ Nokogiri follows [Semantic Versioning](https://semver.org/), please see the [REA * [CRuby] `NodeSet` may now safely contain `Node` objects from multiple documents. Previously the GC lifecycle of the parent `Document` objects could lead to contained nodes being GCed while still in scope. [[#1952](https://github.com/sparklemotion/nokogiri/issues/1952)] * [CRuby] Patch libxml2 to avoid "huge input lookup" errors on large CDATA elements. (See upstream [GNOME/libxml2#200](https://gitlab.gnome.org/GNOME/libxml2/-/issues/200) and [GNOME/libxml2!100](https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/100).) [[#2132](https://github.com/sparklemotion/nokogiri/issues/2132)]. * [CRuby] `{XML,HTML}::Document.parse` now invokes `#initialize` exactly once. Previously `#initialize` was invoked twice on each object. +* [CRuby+Windows] Enable Nokogumbo (and other downstream gems) to compile and link against `nokogiri.so` by including `LDFLAGS` in `Nokogiri::VERSION_INFO`. [[#2167](https://github.com/sparklemotion/nokogiri/issues/2167)] * [JRuby] `{XML,HTML}::Document.parse` now invokes `#initialize` exactly once. Previously `#initialize` was not called, which was a problem for subclassing such as done by `Loofah`. diff --git a/lib/nokogiri/version/info.rb b/lib/nokogiri/version/info.rb index 7a9787ac16..1bfea42908 100644 --- a/lib/nokogiri/version/info.rb +++ b/lib/nokogiri/version/info.rb @@ -89,6 +89,11 @@ def to_hash nokogiri["version"] = Nokogiri::VERSION unless jruby? + # enable gems like nokogumbo to build with the following in their extconf.rb: + # + # append_cflags(Nokogiri::VERSION_INFO["nokogiri"]["cppflags"]) + # append_ldflags(Nokogiri::VERSION_INFO["nokogiri"]["ldflags"]) + # cppflags = ["-I#{header_directory.shellescape}"] ldflags = []