From 15110d6a0026fed33ec3a2ba97b865eba35a910d Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Sun, 16 Oct 2022 13:32:41 -0400 Subject: [PATCH] fix: compiling from source on windows with system libraries specify ldflags to resolve Nokogiri's symbols. --- lib/nokogiri/version/info.rb | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/nokogiri/version/info.rb b/lib/nokogiri/version/info.rb index 6b1ec11430..a5f45283e7 100644 --- a/lib/nokogiri/version/info.rb +++ b/lib/nokogiri/version/info.rb @@ -105,16 +105,16 @@ def to_hash if libxml2_using_packaged? cppflags << "-I#{File.join(header_directory, "include").shellescape}" cppflags << "-I#{File.join(header_directory, "include/libxml2").shellescape}" + end - if windows? - # on windows, nokogumbo needs to link against nokogiri.so to resolve symbols. see #2167 - lib_directory = File.expand_path(File.join(File.dirname(__FILE__), "../#{ruby_minor}")) - unless File.exist?(lib_directory) - lib_directory = File.expand_path(File.join(File.dirname(__FILE__), "..")) - end - ldflags << "-L#{lib_directory.shellescape}" - ldflags << "-l:nokogiri.so" + if windows? + # on windows, nokogumbo needs to link against nokogiri.so to resolve symbols. see #2167 + lib_directory = File.expand_path(File.join(File.dirname(__FILE__), "../#{ruby_minor}")) + unless File.exist?(lib_directory) + lib_directory = File.expand_path(File.join(File.dirname(__FILE__), "..")) end + ldflags << "-L#{lib_directory.shellescape}" + ldflags << "-l:nokogiri.so" end nokogiri["cppflags"] = cppflags