Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanize::page#encoding_error? raises "ArgumentError: invalid byte sequence in UTF-8" when parse error message contains wrong characters. #553

Closed
nejiko96 opened this issue May 21, 2020 · 5 comments · Fixed by #579

Comments

@nejiko96
Copy link

I think this will be avoided by a patch like this:

--- a/lib/mechanize/page.rb
+++ b/lib/mechanize/page.rb
@@ -103,7 +103,7 @@ class Mechanize::Page < Mechanize::File
     parser = self.parser unless parser
     return false if parser.errors.empty?
     parser.errors.any? do |error|
-      error.message =~ /(indicate\ encoding)|
+      error.message.scrub =~ /(indicate\ encoding)|
                         (Invalid\ char)|
                         (input\ conversion\ failed)/x
     end

but it seems like String#scrub requires Ruby version >= 2.1.0.

@flavorjones
Copy link
Member

@nejiko96 Can you help me reproduce the error you'd like to fix?

@nejiko96
Copy link
Author

nejiko96 commented May 8, 2021

require 'mechanize'

agent = Mechanize.new
page = agent.get('https://atcoder.jp/contests/apg4b/tasks/APG4b_r')
page.search('body')
.../mechanize-2.7.7/lib/mechanize/page.rb:108:in `block in encoding_error?': invalid byte sequence in UTF-8 (ArgumentError)
        from .../mechanize-2.7.7/lib/mechanize/page.rb:105:in `any?'
        from .../mechanize-2.7.7/lib/mechanize/page.rb:105:in `encoding_error?'
        from .../mechanize-2.7.7/lib/mechanize/page.rb:126:in `block in parser'
        from .../mechanize-2.7.7/lib/mechanize/page.rb:123:in `reverse_each'
        from .../mechanize-2.7.7/lib/mechanize/page.rb:123:in `parser'
        from .../ruby/2.4.0/forwardable.rb:223:in `search'
        from test.rb:5:in `<main>'

@flavorjones flavorjones reopened this May 9, 2021
@flavorjones
Copy link
Member

Thank you for your help. Working on a fix now.

@flavorjones
Copy link
Member

I've released v2.8.1 which fixes this. Thanks again.

@nejiko96
Copy link
Author

I have confirmed that it is fixed. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants