From 4fc17ae1f868df85a1e5407e93036aac4a091de4 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Fri, 22 Jan 2021 23:38:27 -0500 Subject: [PATCH] test: conditionally skip depending on net-http-persistent < v4 Net::HTTP::Persistent removed `#retry_change_requests` in v4.0.0 and later, so these tests fail if we've pulled in a more recent version than that. Related to https://github.com/drbrain/net-http-persistent/pull/100 --- test/test_mechanize.rb | 5 +++++ test/test_mechanize_http_agent.rb | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/test/test_mechanize.rb b/test/test_mechanize.rb index e5594130..a8b61208 100644 --- a/test/test_mechanize.rb +++ b/test/test_mechanize.rb @@ -1056,6 +1056,11 @@ def test_referer end def test_retry_change_requests_equals + unless Gem::Requirement.new("< 4.0.0").satisfied_by?(Gem::Version.new(Net::HTTP::Persistent::VERSION)) + # see https://github.com/drbrain/net-http-persistent/pull/100 + skip("net-http-persistent 4.0.0 and later does not support retry_change_requests") + end + refute @mech.retry_change_requests @mech.retry_change_requests = true diff --git a/test/test_mechanize_http_agent.rb b/test/test_mechanize_http_agent.rb index 9188a1b7..8827a8d9 100644 --- a/test/test_mechanize_http_agent.rb +++ b/test/test_mechanize_http_agent.rb @@ -1590,6 +1590,11 @@ def test_response_redirect_permanent_temporary end def test_retry_change_request_equals + unless Gem::Requirement.new("< 4.0.0").satisfied_by?(Gem::Version.new(Net::HTTP::Persistent::VERSION)) + # see https://github.com/drbrain/net-http-persistent/pull/100 + skip("net-http-persistent 4.0.0 and later does not support retry_change_requests") + end + refute @agent.http.retry_change_requests @agent.retry_change_requests = true