Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gulp util #157

Merged
merged 4 commits into from Dec 29, 2017
Merged

Remove gulp util #157

merged 4 commits into from Dec 29, 2017

Conversation

spalger
Copy link
Owner

@spalger spalger commented Dec 28, 2017

Fixes #156

@spalger spalger mentioned this pull request Dec 28, 2017
Closed
@demurgos
Copy link

demurgos commented Dec 28, 2017 •
edited

Thanks for the update. Looks good to me.
Could you publish the updated version to npm?

@demurgos demurgos mentioned this pull request Dec 28, 2017
Closed
phated
phated reviewed Dec 29, 2017
View reviewed changes
package.json Outdated
"rcloader": "^0.2.2",
"through2": "^2.0.0"
"through2": "^2.0.0",
"vinyl": "^2.1.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a devDep, right?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it. You are right: vinyl is only used for the tests and should be a devDependency.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to be careful with this because we don't want people inadvertently depending on vinyl if they aren't using it outside of DevDeps.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phated!

@spalger spalger merged commit 2c57c9f into master Dec 29, 2017
@spalger spalger deleted the remove-gulp-util branch December 29, 2017 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated left review comments

@demurgos demurgos demurgos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spalger @demurgos @phated