Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3623: Catch Runtime warnings in jump step #258

Merged
merged 3 commits into from
May 20, 2024
Merged

JP-3623: Catch Runtime warnings in jump step #258

merged 3 commits into from
May 20, 2024

Conversation

drlaw1558
Copy link
Contributor

@drlaw1558 drlaw1558 commented May 14, 2024 •
edited by hbushouse

Resolves JP-3623 by catching a few runtime warnings in the jump step that were no longer caught after recent updates.

Closes spacetelescope/jwst#8483

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@drlaw1558 drlaw1558 requested a review from a team as a code owner May 14, 2024 14:25
@github-actions github-actions bot added the jump label May 14, 2024
@stscijgbot-jp stscijgbot-jp mentioned this pull request May 14, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.00%. Comparing base (af5aefb) to head (e260c12).
Report is 6 commits behind head on main.

❗ Current head e260c12 differs from pull request most recent head dfe2eba

Please upload reports for the commit dfe2eba to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   85.18%   85.00%   -0.19%     
==========================================
  Files          35       35              
  Lines        6797     6867      +70     
==========================================
+ Hits         5790     5837      +47     
- Misses       1007     1030      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kmacdonald-stsci
kmacdonald-stsci reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@kmacdonald-stsci kmacdonald-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change log. Also, is it possible to add a CI test to ensure tests are being reported (or not) as expected?

@drlaw1558
Copy link
Contributor Author

No change log. Also, is it possible to add a CI test to ensure tests are being reported (or not) as expected?

Not sure how to add a test for error messages from these specific locations, but have added a change log entry.

hbushouse
hbushouse approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@hbushouse hbushouse closed this May 17, 2024
@hbushouse
Copy link
Collaborator

Closing and reopening to trigger CI tests.

@hbushouse hbushouse reopened this May 17, 2024
@hbushouse hbushouse merged commit ccd93bb into spacetelescope:main May 20, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@kmacdonald-stsci kmacdonald-stsci kmacdonald-stsci approved these changes

Assignees
No one assigned
Labels
jump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jump step reporting RunTime warnings
3 participants
@drlaw1558 @hbushouse @kmacdonald-stsci