Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptive names, inputs, outputs, and units for WCS transform objects #8444

Open
stscijgbot-jp opened this issue Apr 26, 2024 · 0 comments · May be fixed by #8524
Open

Descriptive names, inputs, outputs, and units for WCS transform objects #8444

stscijgbot-jp opened this issue Apr 26, 2024 · 0 comments · May be fixed by #8524

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3607 was created on JIRA by Ned Molter:

The astropy GWCS module permits assignment of descriptive names of transforms, as well as descriptive labels for their inputs and outputs and default units.  These make it much easier to understand what a transform is doing, and which transform to use in what instance(s).  However, these are inconsistently used in assign_wcs, assign_mtwcs, and perhaps set_telescope_pointing.  For example, in assign_wcs.nircam.tsgrism(), the distortion model takes as inputs (v2, v3, wavelength, order) and as outputs (x, y, wavelength, order), but right now those are labeled ('x00', 'x10', 'x01', 'x11') and ('y0', 'y1', 'x0', 'x1') when calling transform.inputs()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant