Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: swarm config params #20

Closed
avive opened this issue Dec 28, 2017 · 5 comments
Closed

chore: swarm config params #20

avive opened this issue Dec 28, 2017 · 5 comments

Comments

@avive
Copy link
Contributor

avive commented Dec 28, 2017

Feature description

Make all swarm config values command-line and config-file modifiable. Look at SwarmConfigValues - right now the values are hard-coded.

Reasons for adding this feature

This feature will allow us to more easily test swarm features.

@y0sher
Copy link
Contributor

y0sher commented Jan 11, 2018

urfave/cli should load everything pretty smooth even from config files. though it has an open issue about parsing uint(64) and duration types, maybe we should use another toml parser (probably the one used by cli anyway) ?
int is working so maybe just load and cast? though duration is still an issue
reference to issue : urfave/cli#599

@avive
Copy link
Contributor Author

avive commented Jan 12, 2018

i think we should go w the cli parser for now and cast from ints. We should also decide toml vs. yaml and provide some demo config file. for duration i guess we can receive inputs in float or int rperesntijg secs and cast to duration.

@y0sher
Copy link
Contributor

y0sher commented Jan 17, 2018

I discovered that to use the cli parsing feature flag names must be single names
(eg: "tcp" instead of "tcp, t" which enables multiple command line applications to the command)
Anyway you'll see a pr soon. I can use some advices about making the code little bit more generic.

@avive
Copy link
Contributor Author

avive commented Jan 23, 2018

Perhaps parsing the config file ourselves as you suggest and just updating matched flag values is the way to go as it looks like the cli bug is open for almost a year.

@y0sher
Copy link
Contributor

y0sher commented Feb 2, 2018

Done on #69

@y0sher y0sher closed this as completed Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants