Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto flusher available for all platform #1434

Open
vincent-herlemont opened this issue Dec 7, 2022 · 1 comment
Open

Auto flusher available for all platform #1434

vincent-herlemont opened this issue Dec 7, 2022 · 1 comment

Comments

@vincent-herlemont
Copy link

vincent-herlemont commented Dec 7, 2022

Here v0.34.7/src/db.rs#L75-L81 auto flush is restricted.

        #[cfg(all(
            not(miri),
            any(
                windows,
                target_os = "linux",
                target_os = "macos",
                target_os = "dragonfly",
                target_os = "freebsd",
                target_os = "openbsd",
                target_os = "netbsd",
            )
        ))]

@spacejam What is the original reason to restrict it?

I see here that you remove these restrictions. What are the implications? Is it possible to create a release including this commit?

@bwqr
Copy link

bwqr commented Mar 25, 2023

Hi there,

I guess I hit the auto flusher not available for all platform issue where the sled version is 0.34.7. I was developing an iOS application and using sled as persistent key value store. Any call to insert does not get persisted unless I call flush explicitly. Since it is not documented in the readme page, it was time consuming for me to debug this. Is there any reason for not enabling automatic flush in iOS platform? Does the project have any plan to enable this?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants