sig overlap and sig subtract should be upgraded to support more than JSON sigs
#3136
Comments
2 tasks
ctb
added a commit
that referenced
this issue
Jun 4, 2024
…signatures (#3153) Fix `sig overlap` and `sig subtract` to take more than just JSON signatures. Also, adds a function `sourmash_args.load_one_signature` that I think should (eventually) replace the now-deprecated `sourmash.signature.load_one_signature`. This will be the topic of a new PR - for now, I think it's a nice quick fix! Fixes #3136 Related issues: * #1062 - will do another PR to close this issue * #1877 * #1312 * #1060 TODO: - [x] test uncovered code - [x] do a bit more of a search and digest of related issues to see if there's other low hanging fruit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
right now neither of them operate on .sig.zip files AFAICT
The text was updated successfully, but these errors were encountered: