Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rockskip: improve test coverage #62550

Closed
5 tasks done
jtibshirani opened this issue May 8, 2024 · 1 comment
Closed
5 tasks done

Rockskip: improve test coverage #62550

jtibshirani opened this issue May 8, 2024 · 1 comment
Assignees
@jtibshirani @stefanhengl
Labels
team/search-platform Issues owned by the search platform team

Comments

@jtibshirani
Copy link
Member

jtibshirani commented May 8, 2024 •
edited

Tasks
Beta Give feedback
  1. Rockskip: simplify ruler function #62510
    cla-signed team/product-platform team/search-platform
  2. Rockskip: test getHops function #62549
    cla-signed team/product-platform team/search-platform
  3. Rockskip: refactor metrics registration #62557
    cla-signed team/product-platform team/search-platform
  4. Rockskip: add search tests #62581
    cla-signed team/product-platform team/search-platform
  5. Symbols: new backend integration test #62686
    cla-signed team/product-platform team/search-platform

/cc @sourcegraph/search-platform
@jtibshirani jtibshirani added the team/search-platform Issues owned by the search platform team label May 8, 2024
@jtibshirani jtibshirani changed the title Rockskip: simplify + improve test coverage Rockskip: improve test coverage May 10, 2024
@jtibshirani jtibshirani mentioned this issue May 16, 2024
Merged
@jtibshirani
Copy link
Member Author

Closing this out. I'm tracking the final item "Enable Rockskip in integration tests" separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtibshirani jtibshirani

@stefanhengl stefanhengl

Labels
team/search-platform Issues owned by the search platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtibshirani @stefanhengl