Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols sidebar: Extra double-quotes showing up in UI #62483

Open
varungandhi-src opened this issue May 7, 2024 · 0 comments
Open

Symbols sidebar: Extra double-quotes showing up in UI #62483

varungandhi-src opened this issue May 7, 2024 · 0 comments
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. team/code-search Issues owned by the code search team

Comments

@varungandhi-src
Copy link
Contributor

varungandhi-src commented May 7, 2024

Heading names showing up incorrectly in the 'Symbols' sidebar here:

https://sourcegraph.com/github.com/sourcegraph/sourcegraph@008d572e1e9c79b28d0feaf48b09b9dffb2f1152/-/blob/internal/codeintel/uploads/internal/commitgraph/README.md

image

Seems like the frontend is attempting to use the containerName field directly, but it's unclear what the semantics of that are supposed to be. Based on the GraphQL schema entry for containerName, it's unclear what the semantics of it are supposed to be.

Here is a part of the GraphQL response.

{
	"3": {
		"__typename": "Symbol",
		"name": "Visibility rules",
		"containerName": "commitgraph\"\"The annotated commit graph",
		"kind": "UNKNOWN",
		"language": "Markdown",
		"location": {
			"resource": {
				"path": "internal/codeintel/uploads/internal/commitgraph/README.md",
				"__typename": "CodeIntelGitBlob"
			},
			"range": {
				"start": {
					"line": 35,
					"character": 5,
					"__typename": "Position"
				},
				"end": {
					"line": 35,
					"character": 21,
					"__typename": "Position"
				},
				"__typename": "Range"
			},
			"__typename": "Location"
		},
		"url": "/github.com/sourcegraph/sourcegraph@008d572e1e9c79b28d0feaf48b09b9dffb2f1152/-/blob/internal/codeintel/uploads/internal/commitgraph/README.md?L36:6-36:22"
	}
}
@varungandhi-src varungandhi-src added the team/code-search Issues owned by the code search team label May 7, 2024
@varungandhi-src varungandhi-src added the bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. label May 9, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. team/code-search Issues owned by the code search team
Projects
None yet
Development

No branches or pull requests

1 participant