Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config popover to "open in editor" button #62292

Closed
bahrmichael opened this issue Apr 30, 2024 · 0 comments · Fixed by #62452
Closed

Add config popover to "open in editor" button #62292

bahrmichael opened this issue Apr 30, 2024 · 0 comments · Fixed by #62452
Assignees
@bahrmichael
Labels
File team/code-search Issues owned by the code search team
Milestone
Web app rewrite/3

Comments

@bahrmichael
Copy link
Contributor

bahrmichael commented Apr 30, 2024 •
edited

Follow up to #61629.

In #61782 I added an OpenInEditor button for the new webapp. To reduce scope for the ticket I decided to not re-implement the popover that gives users a convenient way to configure an editor. Currently they see a tooltip that tells them to go to the user settings and fill out some JSON over there.

Ideally we would re-implement this popover and our new webapp. We can probably copy&paste a bunch of code from the OpenInEditorAction.tsx from the react app.
@bahrmichael bahrmichael added the team/code-search Issues owned by the code search team label Apr 30, 2024
@bahrmichael bahrmichael added this to the Web app rewrite/3 milestone Apr 30, 2024
@bahrmichael bahrmichael self-assigned this Apr 30, 2024
@bahrmichael bahrmichael mentioned this issue May 6, 2024
Merged
@fkling fkling added webapp-rewrite Issues related to the web app rewrite and removed webapp webapp-rewrite Issues related to the web app rewrite labels May 22, 2024
@fkling fkling added the File label May 22, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahrmichael bahrmichael

Labels
File team/code-search Issues owned by the code search team
Projects
None yet
Milestone
Web app rewrite/3
Development

Successfully merging a pull request may close this issue.

feat: popover to configure editor sourcegraph/sourcegraph
2 participants
@fkling @bahrmichael