Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enterprise-imports ESLint rule #26639

Closed
valerybugakov opened this issue Oct 26, 2021 · 3 comments
Closed

Update enterprise-imports ESLint rule #26639

valerybugakov opened this issue Oct 26, 2021 · 3 comments
Labels
frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. good first issue Good for newcomers sourcegraph-refinement-bot

Comments

@valerybugakov
Copy link
Member

Problem statement

The enterprise-imports ESLint rule would give false positives with absolute imports in files under the enterprise foder.

// src/enterprise/main.ts
import { test } from '@sourcegraph/web/enterprise/test.ts' // should not trigger ESLint error

Success criteria

  1. The enterprise-imports ESLint rule is updated to work with absolute imports in files under the enterprise foder.
  2. dev/check/ts-enterprise-import.sh in dev/check/all.sh is removed.

Things to learn/practice during the implementation

ESLint configuration in monorepos.

Implementation details

Relevant PR that introduced the ESLint rule: #23044

Estimated amount of work

T-shirt size estimate: M.

@valerybugakov valerybugakov added good first issue Good for newcomers frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. labels Oct 26, 2021
@github-actions
Copy link
Contributor

Heads up @umpox @valerybugakov @5h1rU @pdubroy @taylorsperry - the "team/frontend-platform" label was applied to this issue.

@chrishalbert
Copy link

This looks resolved at this point I think.

@valerybugakov
Copy link
Member Author

Yep 👍

Good first issues automation moved this from To do 🛠 to Done 🎉 Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. good first issue Good for newcomers sourcegraph-refinement-bot
Projects
Status: Done
Development

No branches or pull requests

3 participants