Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for special characters in file names #45

Merged
merged 1 commit into from May 8, 2020

Conversation

eseliger
Copy link
Member

@eseliger eseliger commented May 8, 2020

Closes #43

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #45 into master will increase coverage by 1.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   26.91%   28.12%   +1.20%     
==========================================
  Files           5        5              
  Lines        1133     1152      +19     
==========================================
+ Hits          305      324      +19     
  Misses        784      784              
  Partials       44       44              
Impacted Files Coverage Δ
diff/parse.go 80.85% <100.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adde711...51b4e38. Read the comment docs.

Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is stuff from git encoded in the same way that go's Unquote... unquotes? Either way LGTM :)

@eseliger eseliger merged commit 8c3ae63 into master May 8, 2020
@eseliger eseliger deleted the es/quoted-filenames branch May 8, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No proper handling for special characters in file names
2 participants