Update documentation for ParseMultiFileDiff #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=======================================
Coverage 26.91% 26.91%
=======================================
Files 5 5
Lines 1133 1133
=======================================
Hits 305 305
Misses 784 784
Partials 44 44
Continue to review full report at Codecov.
|
sqs
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this when trying to parse a "multi file diff" that I generated by concatenating multiple file diffs without putting a
diff [...] a/<filename> b/<filename>between each single file diff. Reproduction here: https://play.golang.org/p/pxPb6sJfyorThis updates the documentation to describe the behavior and also remove outdated information about error handling.